1. 20 Mar, 2019 1 commit
  2. 19 Mar, 2019 1 commit
  3. 06 Mar, 2019 1 commit
    • Joachim Klein's avatar
      Fix explicit non-prob LTL checking with experiments · 1e04c20c
      Joachim Klein authored
      We did not perform a required deepCopy of the path expression before checking/replacing maximal state formulas, thus modifying the original expression, which breaks later model checking when doing experiments.
      
      Found by Steffen Märcker.
      1e04c20c
  4. 27 Feb, 2019 1 commit
  5. 25 Feb, 2019 8 commits
  6. 06 Feb, 2019 2 commits
    • Joachim Klein's avatar
      Fix evaluateExact for unary minus · 7b8a4628
      Joachim Klein authored
      We should propagate the EvaluateContext into the inner expression.
      
      The missing 'ec' led to exceptions in model construction for exact/parametric mode, as variable valuations are then not available, e.g., when used in guards ('-s' where 's' is a state variable).
      
      Checked the other evaluateExact calls, those are fine.
      7b8a4628
    • Joachim Klein's avatar
      Fix rare crash during GUI startup. · e8788b77
      Joachim Klein authored
      We have observed crashes during GUI startup, during the splash screen phase, with the following exception stack trace:
      
      Exception in thread "main" java.util.ConcurrentModificationException
      	at java.util.Vector$Itr.checkForComodification(Vector.java:1184)
      	at java.util.Vector$Itr.next(Vector.java:1137)
      	at javax.swing.plaf.basic.BasicDirectoryModel$LoadFilesThread.cancelRunnables(BasicDirectoryModel.java:340)
      	at javax.swing.plaf.basic.BasicDirectoryModel$LoadFilesThread.cancelRunnables(BasicDirectoryModel.java:346)
      	at javax.swing.plaf.basic.BasicDirectoryModel.validateFileCache(BasicDirectoryModel.java:135)
      	at javax.swing.plaf.basic.BasicDirectoryModel.propertyChange(BasicDirectoryModel.java:69)
      	at java.beans.PropertyChangeSupport.fire(PropertyChangeSupport.java:335)
      	at java.beans.PropertyChangeSupport.firePropertyChange(PropertyChangeSupport.java:327)
      	at java.beans.PropertyChangeSupport.firePropertyChange(PropertyChangeSupport.java:263)
      	at java.awt.Component.firePropertyChange(Component.java:8422)
      	at javax.swing.JFileChooser.setCurrentDirectory(JFileChooser.java:598)
      	at userinterface.GUIPrism.setupResources(GUIPrism.java:262)
      	at userinterface.GUIPrism.<init>(GUIPrism.java:228)
      	at userinterface.GUIPrism.main(GUIPrism.java:127)
      
      The problem seems to be that creating a JFileChooser and then using setCurrentDirectory a short time later might result in some race condition in the Java platform code (the JFileChooser asynchronously pre-caches the directory contents and has to cancel these threads when the directory is changed). We have also not been able to reliably trigger it.
      
      While this doesn't look to be our fault, we avoid this by doing the currentDir logic before creating the JFileChooser and then passing this directly during the construction of the JFileChooser.
      
      (with Philipp Chrszon)
      e8788b77
  7. 19 Dec, 2018 1 commit
    • Joachim Klein's avatar
      ExportIterations: Switch to HTTPS in PRISM URL · 06bba360
      Joachim Klein authored
      The HTML file generated by the iteration export loads Javascript and
      CSS resources from www.prismmodelchecker.org. Previously, those URLs
      used http as the protocol. If such a generated HTML file was loaded
      via an https-connections, current browsers would reasonably block
      access to the Javascript, as it's not be loaded over a secure
      connection.
      
      As the prismmodelchecker.org site now supports https, we switch to
      https for loading those resources.
      06bba360
  8. 07 Dec, 2018 2 commits
  9. 06 Dec, 2018 3 commits
  10. 05 Dec, 2018 2 commits
  11. 01 Dec, 2018 1 commit
  12. 30 Nov, 2018 4 commits
  13. 21 Nov, 2018 1 commit
    • Joachim Klein's avatar
      param/Makefile: Fix typo · 04982ea7
      Joachim Klein authored
      Fix typo in the variable definition. Changed files under src/param/ were not be recompiled if only files in param/ were changed.
      04982ea7
  14. 25 Oct, 2018 2 commits
  15. 18 Oct, 2018 8 commits
  16. 17 Oct, 2018 1 commit
    • Steffen Märcker's avatar
      Expressions.evaluate (binary,unary,function): Avoid explicit boxing of... · f1b70b67
      Steffen Märcker authored
      Expressions.evaluate (binary,unary,function): Avoid explicit boxing of Booleans, Integers and Doubles
      
      During the evaluate calls, the code previously used 'new Boolean' and 'new
      Integer' constructors for the result values. By removing these allocations
      and simply letting Java take care of boxing the resulting primitive
      values, the integrated caching of Java can avoid creating objects in a
      lot of cases (always for Boolean, and often for Integers in a certain
      range).
      
      (adapted by Joachim Klein from https://github.com/prismmodelchecker/prism/pull/91)
      
      Tag: performance
      f1b70b67
  17. 12 Oct, 2018 1 commit
    • Chris Novakovic's avatar
      Don't hardcode maximum dimensions for DOT graphs · 341efe4d
      Chris Novakovic authored
      When DOT graphs of a model are exported, their maximum permitted size is
      hardcoded to 8 inches wide by 5 inches high, which is too small for the
      rendered drawing to be useful (e.g. during debugging) for all but the
      simplest of models. Remove the maximum size restriction, allowing tools
      to render the drawing with its natural dimensions.
      341efe4d